Improve searchbox event handling#695
Merged
Merged
Conversation
* use "input" rather than "keyup" to respond to value changes, catching previously ignored interactions such as Paste and avoiding the need to special-case Enter/Tab/etc. since those don't trigger an "input" event * call `preventDefault` in the synchronous listener rather than in the debounced function when it's too late * drop attempted "/" suppression, since it wasn't working anyway and apparently hasn't been a problem * consolidate "keydown"/"input" handling into a single debounced listener that switches on event type for deciding its behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preventDefaultin the synchronous listener rather than in the debounced function when it's too late