Merged
Conversation
The spec defines round() as:
round(numFractionalDigits, roundingMode)
where roundingMode is a string, not an options object.
Changed all examples from:
value.round(2, { roundingMode: "floor" })
to:
value.round(2, "floor")
This matches both the spec and the polyfill implementation.
jessealama
force-pushed
the
cookbook-fixes
branch
from
d8ca2e8 to
a1df094
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work was supposed to be included in #196 but were unintentionally dropped.