Merged
Conversation
bakkot
reviewed
Feb 3, 2026
| 1. If _skippedElements_ is *undefined*, then | ||
| 1. Let _skipRemaining_ be 0. | ||
| 1. Else, | ||
| 1. If _skippedElements_ is not one of *+∞<sub>𝔽</sub>*, *-∞<sub>𝔽</sub>*, or an integral Number, throw a *TypeError* exception. |
Member
There was a problem hiding this comment.
No reason to accept -∞ here since we're going to throw below anyway.
Also, I weakly feel that we should coerce to match [].includes, though since we're already handling negative inputs differently it's less important than for e.g. .join.
Member
Author
There was a problem hiding this comment.
We accept -∞ so that we can throw a RangeError for it instead of TypeError.
I don't want to coerce in new APIs unless we feel it's really important to do so, which I don't think is the case here.
Member
There was a problem hiding this comment.
Ah, yeah, the error is a fine reason.
I do not feel it's really important to coerce here although I do think you should call that out in committee explicitly.
michaelficarra
force-pushed
the
second-parameter
branch
from
86d8fc1 to
9489c72
Compare
bakkot
approved these changes
Feb 3, 2026
michaelficarra
force-pushed
the
second-parameter
branch
from
9489c72 to
d3a43c7
Compare
bakkot
reviewed
Feb 3, 2026
michaelficarra
force-pushed
the
second-parameter
branch
2 times, most recently
from
02db3e7 to
04be590
Compare
michaelficarra
force-pushed
the
second-parameter
branch
from
04be590 to
239213e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1.