Skip to content

additional Function.prototype.toString tests#1477

Merged
rwaldron merged 4 commits into
tc39:masterfrom
michaelficarra:additional-F.p.toString-tests
Mar 7, 2018
Merged

additional Function.prototype.toString tests#1477
rwaldron merged 4 commits into
tc39:masterfrom
michaelficarra:additional-F.p.toString-tests

Conversation

@michaelficarra

Copy link
Copy Markdown
Member

This reflects some recent changes in the Function.prototype.toString revision proposal. I recommend reviewing the commits individually. The final commit adds a test that reflects the current status of the proposal, but will not pass in any current implementations. But it's good to add it, as it will make whatever change we make in the future (assuming we do make one) clear.

@rwaldron rwaldron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwaldron

rwaldron commented Mar 7, 2018

Copy link
Copy Markdown
Contributor

As this proposal is Stage 3, this is ok to land!

@rwaldron rwaldron merged commit 3207bf7 into tc39:master Mar 7, 2018
@michaelficarra michaelficarra deleted the additional-F.p.toString-tests branch March 7, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants