Skip to content

First set of tests for Top Level Await#2271

Closed
leobalter wants to merge 3 commits into
tc39:masterfrom
leobalter:2218/top-level-await-first
Closed

First set of tests for Top Level Await#2271
leobalter wants to merge 3 commits into
tc39:masterfrom
leobalter:2218/top-level-await-first

Conversation

@leobalter

Copy link
Copy Markdown
Member

First goal here is to cover syntax tests for:

ModuleItem : StatementListItem[~Yield, +Await, ~Return]

ExportDeclaration :
  export VariableStatement[~Yield, +Await]
  export Declaration[~Yield, +Await]
  export default HoistableDeclaration[~Yield, +Await, +Default]
  export default ClassDeclaration[~Yield, +Await, +Default]
  export default [lookahead ∉ { function, async [no LineTerminator here] function, class }] AssignmentExpression[+In, ~Yield, ~Await] ;

@leobalter leobalter force-pushed the 2218/top-level-await-first branch from 75884d2 to 236835d Compare August 2, 2019 22:21
@leobalter leobalter force-pushed the 2218/top-level-await-first branch from 236835d to 87ae7b4 Compare August 2, 2019 22:29
@leobalter leobalter requested a review from rwaldron August 2, 2019 22:31
@leobalter leobalter self-assigned this Aug 2, 2019
rwaldron
rwaldron previously approved these changes Aug 5, 2019

@rwaldron rwaldron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the first 2 commits


assert.sameValue(fn(), 2);

$DONE();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 love it.

features: [top-level-await]
---*/

await [];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@rwaldron rwaldron changed the title [WIP] First set of tests for Top Level Await First set of tests for Top Level Await Aug 5, 2019
@rwaldron

rwaldron commented Aug 6, 2019

Copy link
Copy Markdown
Contributor

I fixed this locally, rebased and merged into master.

@rwaldron rwaldron closed this Aug 6, 2019
@leobalter leobalter deleted the 2218/top-level-await-first branch August 13, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants