Skip to content

Conversation

@arv
Copy link
Member

@arv arv commented Jun 25, 2015

It was missing vars which was causing issues with our test harness
since we run all the files in strict mode.

It was missing vars which was causing issues with our test harness
since we run all the files in strict mode.
@arv
Copy link
Member Author

arv commented Jun 25, 2015

@bterlson @jugglinmike PTAL

@arv
Copy link
Member Author

arv commented Jun 25, 2015

More background: The V8 test harness runs d8 with --use-strict command line flag and therefore this file fails to parse.

@jugglinmike
Copy link
Contributor

This looks good to me. I don't understand how this ever worked in strict mode.

Also, @arv, doesn't running with d8 --use_strict invalidate all the tests that specify noStrict?

bterlson added a commit that referenced this pull request Jun 25, 2015
Fix issue with math_precision.js
@bterlson bterlson merged commit 55740e9 into tc39:master Jun 25, 2015
@arv
Copy link
Member Author

arv commented Jun 25, 2015

@jugglinmike noStrict and onlyStrict are taken into account.

https://github.com/v8/v8-git-mirror/blob/master/test/test262-es6/testcfg.py#L84

@jugglinmike
Copy link
Contributor

Oooh. I thought you meant you were running with --use_strict unconditionally, as in:

test262.py --command "d8 --use_strict"

@arv
Copy link
Member Author

arv commented Jun 25, 2015

We do not use the test runner provided by tc39/test262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants