Add tests for \p{…} with properties of strings#3360
Merged
Conversation
mathiasbynens
commented
Dec 27, 2021
2 tasks
This functionality is part of the RegExp `v` flag proposal: https://github.com/tc39/proposal-regexp-set-notation
mathiasbynens
force-pushed
the
properties-of-strings
branch
from
d28b9f2 to
3db89cf
Compare
rwaldron
approved these changes
Jan 4, 2022
rwaldron
left a comment
rwaldron
left a comment
Contributor
There was a problem hiding this comment.
Thanks for covering all of the admin parts on this!
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality is part of the RegExp
vflag proposal: https://github.com/tc39/proposal-regexp-set-notation This patch adds exhaustive tests that verifies every supported property of strings matches every single string it needs to. The tests also include some similar-looking-but-different strings and ensure those aren’t matched.The code that generated the tests is here: mathiasbynens/unicode-property-escapes-tests#10 However, please review this PR containing only the generated output, and let me know what needs changing. I’ll happily update the test generator accordingly.
Note: This proposal is not yet at Stage 3, so you may want to hold off on merging the PR. However, I’d like to get your reviews already so that I can address any feedback in the test generator.