Update Intl.DurationFormat test with recent default digital style change#3714
Closed
Update Intl.DurationFormat test with recent default digital style change#3714
Conversation
When the provided `style` is digital, the default `listStyle` has been changed from "narrow" to "short". In the "en" locale, this adds commas between the units. tc39/proposal-intl-duration-format@7495e32
ptomato
added
the
awaiting consensus
Member
|
cc @ryzokuken |
ryzokuken
approved these changes
Mar 6, 2023
Contributor
|
tc39/proposal-intl-duration-format#127 is still awaiting consensus in TC39. |
Contributor
|
@ryzokuken could you bring tc39/proposal-intl-duration-format#127 to TG1 and TG2 to make sure we can close this issue and land this PR into test262? |
Contributor
|
This has been fixed in #3895. |
Contributor
|
We should close this PR. it is dup as @anba mentioned. |
Contributor
|
OK, thanks for pointing that out. Also thank you @trflynn89 for submitting it initially. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the provided
styleis digital, the defaultlistStylehas been changed from "narrow" to "short". In the "en" locale, this adds commas between the units.tc39/proposal-intl-duration-format@7495e32