Allow global var-via-eval be declared#4046
Merged
Merged
Conversation
ptomato
approved these changes
Apr 9, 2024
ptomato
left a comment
ptomato
left a comment
Contributor
There was a problem hiding this comment.
Looks like this accurately covers the proposal, both var and function declarations inside eval, and both let and const bindings shadowing. Thanks!
ptomato
force-pushed
the
rm-sloppy-direct-eval-vars
branch
from
7013c6a to
8affb36
Compare
Contributor
|
Proposal is stage 3 now, assuming no other reviews are forthcoming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See tc39/ecma262#3226
cc @shvaikalesh who originally authored these tests.