Add tests for TypedArrays#includes#641
Closed
leobalter wants to merge 2 commits into
Closed
Conversation
|
|
||
| sample = new TA(42); | ||
| assert.sameValue(sample.includes(0, 42), false); | ||
| assert.sameValue(sample.includes(0, 43), false); |
Contributor
There was a problem hiding this comment.
This test would be more interesting if the array contained the searchElement (just like in fromIndex-infinity.js)
Member
Author
There was a problem hiding this comment.
it contains the element, all of them are 0s.
Contributor
There was a problem hiding this comment.
Arg, you are correct. I got confused by the second parameter, somehow.
Member
Author
There was a problem hiding this comment.
I revisited this file several times because of the second parameter as well, but they are still good assertions, I believe.
Contributor
|
Nice work, Leo! |
Member
Author
|
Thanks :) |
Contributor
|
Squashed and merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.