Add tests for async generator function expressions#821
Merged
Conversation
| type: SyntaxError | ||
| ---*/ | ||
|
|
||
| (async function*(x = 1) {"use strict"}); |
There was a problem hiding this comment.
Is there a way to assert that this actually throws an error?
Member
There was a problem hiding this comment.
this is already expected to throw an early error, see line 10 for the negative flag expecting an early SyntaxError.
caitp
force-pushed
the
AsyncGeneratorExpressions
branch
from
26c33e6 to
c43a36a
Compare
|
Hey, are the tests @thefourtheye wrote there? |
Contributor
Author
|
I haven't added the tests added by you other guys, because I think you should all submit separate pull requests to tc39/test262, rather than me submitting them... I've said this 3 times now on several different repositories. |
Contributor
|
@caitp I completely agree. |
rwaldron
requested changes
Jan 19, 2017
| type: SyntaxError | ||
| ---*/ | ||
|
|
||
| (async function*(a = super.prop { }); |
Contributor
There was a problem hiding this comment.
Typo
- (async function*(a = super.prop { });
+ (async function*(a = super.prop) { });
Contributor
Author
There was a problem hiding this comment.
done, thanks for finding that
caitp
force-pushed
the
AsyncGeneratorExpressions
branch
from
c43a36a to
995b9af
Compare
rwaldron
approved these changes
Jan 19, 2017
Contributor
|
Thanks @caitp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP tests for tc39/proposal-async-iteration#69