Skip to content

Document min/max/minmax#232

Merged
tcbrindle merged 3 commits intotcbrindle:mainfrom
spinicist:max_doc
Apr 14, 2025
Merged

Document min/max/minmax#232
tcbrindle merged 3 commits intotcbrindle:mainfrom
spinicist:max_doc

Conversation

@spinicist
Copy link
Contributor

@spinicist spinicist commented Mar 12, 2025

As on the discussions, documented when min/max/minmax will return a nullopt.

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (92616eb) to head (34f8eb2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          69       69           
  Lines        2632     2632           
=======================================
  Hits         2587     2587           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tcbrindle
Copy link
Owner

Hi @spinicist, I finally got CI working again so I could check this! Looks good except for a tiny issue with a missing indent which I fixed.

Thanks very much, and apologies for the delay in merging this.

@tcbrindle tcbrindle merged commit 1f79a37 into tcbrindle:main Apr 14, 2025
41 checks passed
@spinicist
Copy link
Contributor Author

Thanks @tcbrindle, great news that you fixed the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants