Conversation
tcharding
force-pushed
the
08-07-upgrade-bitcoin
branch
2 times, most recently
from
0f30849 to
f95728a
Compare
tcharding
force-pushed
the
08-07-upgrade-bitcoin
branch
from
f95728a to
001000d
Compare
tcharding
changed the title
bitcoin v0.32.2bitcoin version
tcharding
force-pushed
the
08-07-upgrade-bitcoin
branch
2 times, most recently
from
bad7756 to
cf27280
Compare
Somehow a bunch of files from `bitcoin` snuck into `miniscript`, they are not built and should not be here - remove them.
tcharding
force-pushed
the
08-07-upgrade-bitcoin
branch
from
cf27280 to
4efcb53
Compare
Includes upgrade to: - bitcoin v0.32.2 - miniscript v12.2.0 - secp256k1 v0.29.0 - bitcoin-internals v0.3.0 To upgrade we need to make the v0 module mirror the code in rust-bitcoin::psbt, by diffing the files that is reasonably easy to do and only slightly error prone - would be great if someone else would diff and view as well. It gets wild in the v2 module because we copied code from the v0 module then modified it for PSBT v2. All changes to the v2 module need going over very carefully.
tcharding
force-pushed
the
08-07-upgrade-bitcoin
branch
from
4efcb53 to
4b7f974
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes upgrade to:
To upgrade we need to make the v0 module mirror the code in rust-bitcoin::psbt, by diffing the files that is reasonably easy to do and only slightly error prone - would be great if someone else would diff and view as well.
It gets wild in the v2 module because we copied code from the v0 module then modified it for PSBT v2. All changes to the v2 module need going over very carefully.