Conversation
added 2 commits
October 9, 2025 12:52
Introduces the `ExileCallRecording` entity to the Exile Gate API, enabling the representation and handling of call recording data within the system. This includes defining the structure of the `ExileCallRecording` message, along with its associated fields, and integrating it into the `Event` message to facilitate event-driven processing of call recording events.
Adds the zone where the call recording is stored. This allows for better management and organization of recordings across different storage locations.
added 3 commits
October 10, 2025 10:34
Removes the `zone` field from the `ExileCallRecording` message. The zone field is no longer required as the storage location is determined by other mechanisms.
Adds the campaign ID (TaskGroupSid) to the dial response to associate the call with a manual dial campaign.
namtzigla
reviewed
Oct 13, 2025
tcnapi/exile/gate/v2/entities.proto
Outdated
| // The phone number of the client. | ||
| string client_phone = 6; | ||
| // The name of the campaign. | ||
| string campaign = 7; |
Member
There was a problem hiding this comment.
we should not expose the campaign name!
tcnapi/exile/gate/v2/entities.proto
Outdated
| // The duration of the recording. | ||
| google.protobuf.Duration duration = 4; | ||
| // The phone number of the agent. | ||
| string agent_phone = 5; |
tcnapi/exile/gate/v2/public.proto
Outdated
| // will be removed in a future version. | ||
| string caller_sid = 9 [deprecated = true]; | ||
| // Manual dial campaign ID (TaskGroupSid) for the call | ||
| int64 campaign_id = 10; |
Member
There was a problem hiding this comment.
we should not expose this of it this is impossible it should be a string
namtzigla
reviewed
Oct 13, 2025
tcnapi/exile/gate/v2/entities.proto
Outdated
|
|
||
| message ExileCallRecording { | ||
| // The unique identifier of the recording. | ||
| string id = 1; |
added 2 commits
October 14, 2025 09:19
Updates the ExileCallRecording proto definition by renaming the 'id' field to 'recording_id' and renumbers some fields. Removes unused fields from the ExileCallRecording proto. Removes campaign_id from the DialResponse proto.
Adds the organization ID to the ExileCallRecording message. The organization ID allows the system to identify which organization the call recording belongs to.
namtzigla
approved these changes
Oct 14, 2025
tcnapi/exile/gate/v2/entities.proto
Outdated
| // The phone number of the agent. | ||
| string agent_phone = 5; | ||
| // The phone number of the client. | ||
| string client_phone = 6; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for call recordings in the Exile Gate API, including a new entity for call recordings and updates to event handling. The changes primarily add a new
ExileCallRecordingmessage, an associatedRecordingTypeenum, and update the event system to include call recording events. The changes also refactor the definition ofRecordingTypeto avoid duplication.Call Recording Entity Additions:
ExileCallRecordingmessage toentities.proto, which includes fields for recording metadata such as IDs, duration, phone numbers, campaign, recording type, timestamps, and storage zone.RecordingTypeenum inentities.prototo specify the type of recording (TCN, External, Voicemail).google/protobuf/duration.prototo support the duration field inExileCallRecording.Event System Updates:
call_recordingfield of typeExileCallRecordingto theEventmessage inpublic.proto, allowing events to reference call recordings.Refactoring for Consistency:
RecordingTypeenum frompublic.prototo centralize its definition inentities.proto.