Skip to content

Conversation

@vitalca
Copy link
Contributor

@vitalca vitalca commented Nov 7, 2022

Related issue: #323

@jenkins-juliogonzalez
Copy link
Member

Can one of the admins verify this patch?

@vitalca vitalca changed the title Add support for user-defined data types Add support for user-defined data types (Sybase only) Nov 9, 2022
@GeoffMontee
Copy link
Collaborator

Test this, please

@jenkins-juliogonzalez
Copy link
Member

Test PASSed.

@juliogonzalez
Copy link
Member

Let's test it again, and if so, maybe it can be merged.

Test this, please.

@jenkins-juliogonzalez
Copy link
Member

Test PASSed.

@GeoffMontee
Copy link
Collaborator

Hi @vitalca ,

Thanks for the PR! Sorry for letting this one sit for a while.

What do you think about the following changes for this?:

  • Allow different foreign servers to have different keep_untranslatable_types values by changing it from a custom boolean variable to a server option defined in src/options.c
  • Add some documentation for keep_untranslatable_types to ForeignServerCreation.md

@vitalca
Copy link
Contributor Author

vitalca commented Jul 20, 2023

Hi @GeoffMontee,

That makes sense. Thanks for the suggestion!
I am a Java developer, but what you suggested is seemingly easy to implement. Let me give it a try.

@lcnogueirajr
Copy link

In which version will this feature be implemented?

@juliogonzalez
Copy link
Member

@lcnogueirajr, I think we first need @vitalca addressing @GeoffMontee comment.

Now that 2.0.5 is out, it's too late for it, but nothing prevents a 2.0.6 after this is fixed and merged.

@vitalca vitalca closed this Nov 27, 2025
@vitalca
Copy link
Contributor Author

vitalca commented Nov 27, 2025

New PR has been created

@GeoffMontee
Copy link
Collaborator

Thank you, @vitalca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants