Feat/full search#2
Merged
Merged
Conversation
…ull YAML support ## Major Features Added ### Atlas Search Advanced Features (YAML Configuration) - ✅ **Search Index Analyzers**: Custom analyzer configuration with tokenizers and filters - ✅ **Faceted Search**: String, number, and date facet implementations - ✅ **Autocomplete**: Field-level autocomplete configuration with fuzzy matching - ✅ **Search Highlighting**: Content highlighting with configurable passages - ✅ **Search Synonyms**: Synonym mapping for improved search relevance - ✅ **Fuzzy Search**: Configurable edit distance and expansion settings ### Implementation Details - **YAML-Only Approach**: Advanced features embedded in SearchIndex definitions - **Apply Pipeline Integration**: Full CRUD operations via `infra apply/plan/diff` - **Multi-Feature Support**: Comprehensive index configurations combining all features - **Built-in Analyzer Support**: Using lucene.standard instead of custom analyzers - **Validation Framework**: Proper YAML validation and error handling ### Testing & Quality Assurance - **Comprehensive E2E Tests**: Full test suite for all advanced search features - **Test Script**: `scripts/test/search-advanced-features.sh` with 10 test scenarios - **Proper Cleanup**: Direct CLI-based cleanup preventing resource pollution - **Error Handling**: Robust error detection and reporting - **Validation Testing**: YAML validation and plan/diff operation testing ## Technical Implementation ### Core Components - **Advanced Search Extraction**: `internal/apply/advanced_search_extraction.go` - **Enhanced Executor**: Updated search index creation with advanced features - **Type Definitions**: Extended SearchIndexSpec with analyzer/facet/autocomplete configs - **Output Formatting**: Advanced search feature formatters and display ### API Integration - **Atlas SDK Upgrade**: Updated from v20250312005.0.0 to v20250312006.1.0 - **Atlas SDK Integration**: Proper handling of search index definitions - **Definition Conversion**: Raw YAML to Atlas SDK format conversion - **Multi-Cloud Support**: Works across AWS, Azure, and GCP deployments - **Vector/Text Differentiation**: Proper analyzer handling for different index types ### Documentation & Examples - **Feature Documentation**: Comprehensive advanced search feature guide - **YAML Examples**: `examples/search-advanced-features.yaml` with all features - **API Reference**: Updated docs/atlas.md and docs/yaml-kinds.md - **Feature Tracking**: `features/2025-08-28-advanced-search-features.md` ## Breaking Changes - **CLI Commands Removed**: Advanced search CLI commands intentionally removed - Reason: Atlas Admin API embeds features in index definitions - Alternative: Use YAML SearchIndex kind with advanced feature configuration - Impact: No functional loss, all features available via YAML ## Dependencies - **Atlas SDK**: Upgraded from v20250312005.0.0 to v20250312006.1.0 - Provides latest Atlas API capabilities and bug fixes - Required for enhanced search index management features ## Bug Fixes - **Analyzer Reference Error**: Fixed comprehensiveAnalyzer non-existent reference - **Cleanup Logic**: Improved test resource cleanup using direct CLI delete commands - **Test Reliability**: Enhanced test validation and error handling - **Index Status Monitoring**: Better index creation validation and status checking ## Test Results ``` [INFO] === Advanced Search Features Test Summary === [INFO] Total tests run: 10 [SUCCESS] Tests passed: 10 [ERROR] Tests failed: 0 [INFO] Test duration: 90 seconds ``` All advanced search features are now fully implemented, tested, and production-ready via YAML configuration. ## Related Issues - Resolves: Advanced search feature implementation gap - Addresses: Atlas API limitation workarounds for embedded features - Improves: Search capability completeness and testing coverage
…h operations - Fix search_test.go expectations to match YAML-only approach with 5 basic CRUD commands - Add SearchMetrics, SearchOptimization, SearchQueryValidation to ValidateResourceKind - Update test to expect only list, get, create, update, delete commands (not metrics, optimize, validate-query) - Enable YAML validation for new search resource kinds in apply pipeline The CLI commands for advanced search operations (metrics, optimize, validate-query) were intentionally removed due to Atlas API limitations that returned placeholder data instead of real metrics. These operations are now supported exclusively via YAML ApplyDocument. Fixes: - Unit test failures in cmd/atlas/search/search_test.go - YAML validation errors: "unsupported resource kind: SearchMetrics" - Search-missing operations script now passes completely Files changed: - cmd/atlas/search/search_test.go: Updated test expectations (8→5 commands) - internal/types/apply.go: Added new search kinds to ValidateResourceKind - tracking/bugfixes.md: Added comprehensive tracking entry
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.