Conversation
- model/drawingTypes.ts: Point, Stroke, TextItem, DrawingCanvasRef 추출 + ReadonlyPoint, ReadonlyStroke (불변 참조용, deepCopy 줄이는 기반) + StrokeBounds (지우개 히트 테스트 최적화 기반) - model/strokeUtils.ts: deepCopyStrokes, deepCopyTexts, safeMax 추출 + computeStrokeBounds (single-pass O(n) AABB 계산) - smoothing.ts: 로컬 Point 제거, drawingTypes에서 import - DrawingCanvas.tsx: 인라인 타입/유틸 제거, model에서 import - index.ts: 새 타입/유틸 re-export 추가 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DrawingCanvas에서 타입과 유틸리티를
model/디렉토리로 추출. readonly 타입(ReadonlyPoint, ReadonlyStroke)과 StrokeBounds 타입을 도입하여 후속 이슈(MAT-358 undo/redo, MAT-360 지우개 최적화)의 기반을 마련.Linear
Changes
model/drawingTypes.ts: Point, Stroke, TextItem, DrawingCanvasRef 추출 + ReadonlyPoint, ReadonlyStroke, StrokeBounds 추가model/strokeUtils.ts: deepCopyStrokes, deepCopyTexts, safeMax 추출 + computeStrokeBounds (single-pass O(n)) 추가smoothing.ts: 로컬 Point 제거, drawingTypes에서 importDrawingCanvas.tsx: 인라인 타입/유틸 제거, model에서 importindex.ts: 새 타입/유틸 re-export 추가Testing
pnpm --filter @repo/pointer-native-drawing lint통과Risk / Impact
@repo/pointer-native-drawing패키지 내부 구조 변경만. 외부 API 동일