[chore/MAT-655] monorepo lint/typecheck/format 인프라 정합#336
Merged
Conversation
Addresses several pre-existing infrastructure drift issues:
1. Admin typecheck silent pass (MAT-655)
- apps/admin/package.json: typecheck "tsc --noEmit" -> "tsc -b --noEmit"
so composite references (tsconfig.app.json + tsconfig.node.json) are
actually checked.
- Fix 6 accumulated TS errors the silent script was hiding:
* EditConceptModal MouseEvent generic widened to HTMLElement
* adminPermissions.ts non-null assertion after length guard
* useInvalidate invalidateNotice/MockExamResults use array-prefix
queryKey for partial-match invalidation without studentId param
* useProblemEssentialInput ProblemType -> CreateType ('GICHUL_PROBLEM'
belongs to CreateType, not ProblemType)
2. Native lint missing from CI
- package.json ci:lint switched from filtered list to plain
"turbo lint" so every workspace runs (including native expo lint).
- Auto-fix 33 native lint errors surfaced by new enforcement.
3. Prettier plugin version drift
- apps/native/.prettierrc added so prettier nearest-wins config
picks up native's local prettier-plugin-tailwindcss@0.5.14
(NativeWind 4 / Tailwind v3) instead of root v0.6.14 (admin
Tailwind v4).
4. Turbo pipeline inputs
- turbo.json lint/typecheck declare explicit inputs (eslint, prettier,
tsconfig) so cache invalidates on config changes.
Verification:
- pnpm typecheck PASS (5/5 workspaces)
- pnpm ci:lint PASS (5/5, native now included)
- pnpm format:check PASS
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CI typecheck was failing after admin tsc -b enforcement because admin depends on: - @repo/pointer-editor-v2 dist/ (workspace package, not built by pnpm install) - routeTree.gen.ts (generated by @tanstack/router-plugin during vite build) Changes: - turbo.json typecheck: dependsOn ['^typecheck', '^build'] so workspace packages build their dist/ before any typecheck runs. - apps/admin typecheck script: 'tsr generate && tsc -b --noEmit' so routeTree.gen.ts is regenerated before composite typecheck runs. - Add @tanstack/router-cli as devDep for tsr CLI. - Remove invalidateNotice (dead code, zero callers) from useInvalidate to avoid the array-prefix queryKey shim that broke pattern parity with the rest of the file.
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Monorepo의 lint/typecheck/format 인프라가 workspace별로 분산·drift되어 (1) admin typecheck가 코드 에러를 silent 통과시키고 (2) native lint가 CI에서 사실상 안 돌고 (3) prettier 플러그인 버전 충돌로 PR-2(#334)에서도 CI fail이 났던 부분을 한 번에 정합화합니다.
Linear
Changes
1. Admin typecheck silent pass 수정 (MAT-655)
apps/admin/package.jsontypecheck script:tsc --noEmit→tsc -b --noEmit(composite references 추적)EditConceptModal.tsxMouseEvent generic을HTMLDivElement→HTMLElement로 확장 (호출자가<button>)adminPermissions.ts:288matches[0]!.itemnon-null 단언 (matches.length === 0가드 직후)useInvalidate.tsinvalidateNotice/invalidateMockExamResults를 array-prefix queryKey로 변경 (부분 매치 invalidation — required studentId query param 우회)useProblemEssentialInput.tsProblemTypeimport →CreateType으로 정정 ('GICHUL_PROBLEM'은 CreateType 소속, ProblemType은 MAIN/CHILD)2. Native lint를 CI에 포함
package.jsonci:lint:turbo lint --filter=...→turbo lint(모든 workspace 실행, native expo lint 포함)lint --fix로 자동 정리3. Prettier 플러그인 scope 분리
apps/native/.prettierrc신규 — root는 admin(Tailwind v4) 기준prettier-plugin-tailwindcss@^0.6.14, native는 NativeWind 4 + Tailwind v3 기준v0.5.14. prettier의 nearest-wins 정책으로 native 파일은 native 로컬 플러그인이 정렬4. Turbo 캐시 무결성
turbo.jsonlint/typecheck task에inputs명시 (eslint config, prettier config, tsconfig) — config 변경 시 캐시 자동 무효화Testing
로컬 검증 (worktree
.omc/worktrees/infra):pnpm typecheckPASS (5/5 workspaces)pnpm ci:lintPASS (5/5, native 포함)pnpm format:checkPASSRisk / Impact