Skip to content

Account local ChatIds in ChatRepository.favoriteChat#903

Merged
SleepySquash merged 4 commits intomainfrom
836-account-local-chat-when-adding-favorite
Mar 13, 2024
Merged

Account local ChatIds in ChatRepository.favoriteChat#903
SleepySquash merged 4 commits intomainfrom
836-account-local-chat-when-adding-favorite

Conversation

@kvbykov
Copy link
Copy Markdown
Contributor

@kvbykov kvbykov commented Mar 12, 2024 •
edited by SleepySquash
Loading

Resolves #836

Synopsis

Добалвение локального чата в избранное приводит к ошибке

Solution

Вызывать ensureRemoteDialog, если ChatId.isLocal

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@kvbykov kvbykov added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Mar 12, 2024
@kvbykov kvbykov added this to the 0.1.0-alpha.13 milestone Mar 12, 2024
@kvbykov kvbykov self-assigned this Mar 12, 2024
@kvbykov kvbykov marked this pull request as draft March 12, 2024 13:41
@kvbykov
Copy link
Copy Markdown
Contributor Author

kvbykov commented Mar 12, 2024 •
edited by SleepySquash
Loading

FCM

Account local `ChatId`s in `ChatRepository.favoriteChat()` (#903, #836)

@kvbykov kvbykov marked this pull request as ready for review March 12, 2024 13:53
@kvbykov kvbykov requested a review from SleepySquash March 12, 2024 14:51
@SleepySquash SleepySquash added k::refactor Refactor changes of existing code and removed k::UI/UX UI (user interface) and UX (user experience) changes labels Mar 13, 2024
@SleepySquash SleepySquash merged commit 813cbb6 into main Mar 13, 2024
@SleepySquash SleepySquash deleted the 836-account-local-chat-when-adding-favorite branch March 13, 2024 09:27
github-actions bot added a commit that referenced this pull request Mar 13, 2024
@github-actions
Account local ChatIds in ChatRepository.favoriteChat() (#903, #836)
8ff0f26 
813cbb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@kvbykov kvbykov

Labels

enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code

Projects

Roadmap
Status: Done

Milestone

0.1.0-alpha.13

Development

Successfully merging this pull request may close these issues.

Account local ChatIds in ChatRepository.favoriteChat

2 participants

@kvbykov @SleepySquash