removed indexer limit switches and preloading functionality#424
Merged
removed indexer limit switches and preloading functionality#424
Conversation
elleryjh
reviewed
Mar 20, 2026
| Commands.parallel( | ||
| intake.holdAngleAndIntake(IntakeConstants.EXTEND_POS), orchestrator.preloadBalls()) | ||
| .withTimeout(10.0)); | ||
| Commands.parallel(intake.holdAngleAndIntake(IntakeConstants.EXTEND_POS)).withTimeout(10.0)); |
Contributor
There was a problem hiding this comment.
This doesn't need to be in a parallel() because there's just one command.
| Commands.parallel( | ||
| intake.holdAngleAndIntake(IntakeConstants.EXTEND_POS), | ||
| orchestrator.preloadBalls()))); | ||
| Commands.parallel(intake.holdAngleAndIntake(IntakeConstants.EXTEND_POS)))); |
Contributor
There was a problem hiding this comment.
just one command, so remove it from parallel() - a few places in this file.
| package frc.robot.subsystems.indexer; | ||
|
|
||
| import static frc.robot.Schematic.indexerFeedupCanId; | ||
| import static frc.robot.Schematic.indexerLeftLimitSwitchDIO; |
Contributor
There was a problem hiding this comment.
remove these from Schematic too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed indexer limit switches and preloading functionality