Endpoint for login and a test endpoint for the token generated#37
Merged
Endpoint for login and a test endpoint for the token generated#37
Conversation
Contributor
|
@mwitte98 I'm checking this now, but we were gonna just do session and not have any tokens? Does rails give us an authed session automatically? That will get checked on endpoints marked as needed auth? If we use session (over token based) there's little to no work that needs to deal with keeping auth on the client side. |
Contributor
Author
|
@7imbrook rails 5 api doesn't have session middleware by default. I could add it in and store tokens in session cookies if that's easier? |
Contributor
|
@mwitte98 yeah lets do that instead of Auth headers |
7imbrook
approved these changes
Oct 3, 2016
Contributor
7imbrook
left a comment
There was a problem hiding this comment.
I'm gonna approve this so we can start having endpoints to hit, but we can move to sessions in a new PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue #21
Changes: