Skip to content

Endpoint for login and a test endpoint for the token generated#37

Merged
mwitte98 merged 2 commits intomasterfrom
witte/users-backend
Oct 3, 2016
Merged

Endpoint for login and a test endpoint for the token generated#37
mwitte98 merged 2 commits intomasterfrom
witte/users-backend

Conversation

@mwitte98
Copy link
Copy Markdown
Contributor

@mwitte98 mwitte98 commented Oct 3, 2016

Related Issue #21

Changes:

  • Users db table created
  • Endpoint for login that returns a json web token
  • Test endpoint to verify the token works

@7imbrook
Copy link
Copy Markdown
Contributor

7imbrook commented Oct 3, 2016

@mwitte98 I'm checking this now, but we were gonna just do session and not have any tokens? Does rails give us an authed session automatically? That will get checked on endpoints marked as needed auth? If we use session (over token based) there's little to no work that needs to deal with keeping auth on the client side.

@mwitte98
Copy link
Copy Markdown
Contributor Author

mwitte98 commented Oct 3, 2016

@7imbrook rails 5 api doesn't have session middleware by default. I could add it in and store tokens in session cookies if that's easier?

@7imbrook
Copy link
Copy Markdown
Contributor

7imbrook commented Oct 3, 2016

@mwitte98 yeah lets do that instead of Auth headers

Copy link
Copy Markdown
Contributor

@7imbrook 7imbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna approve this so we can start having endpoints to hit, but we can move to sessions in a new PR

@mwitte98 mwitte98 merged commit 79be6a4 into master Oct 3, 2016
@mwitte98 mwitte98 deleted the witte/users-backend branch October 4, 2016 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants