feat(slugrunner):update stack to heroku-18#7
Merged
Cryptophobia merged 1 commit intoteamhephy:masterfrom Oct 30, 2018
Merged
Conversation
Cryptophobia
requested changes
Oct 28, 2018
Member
Cryptophobia
left a comment
Cryptophobia
left a comment
There was a problem hiding this comment.
Just a minor commit message change here as well before we merge. Can you change the commit message to follow the style: https://docs.teamhephy.com/contributing/submitting-a-pull-request/#commit-style
Member
Author
|
It has been changed, but my English is not very good, I am sorry. |
Cryptophobia
approved these changes
Oct 30, 2018
Member
|
Thanks @duanhongyi ! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade heroku-images to heroku-18, cooperate with slugbuilder