Bulk create and notify events #109
Conversation
src/collections/events.coffee
Outdated
There was a problem hiding this comment.
We should include validation / appropriate error messages here.
There was a problem hiding this comment.
Missing a few things:
- Tests
- Minor bump.
- Update CHANGELOG
There was a problem hiding this comment.
Also looking in v3, I don't see this command. Am I missing something?
There was a problem hiding this comment.
Its here, https://github.com/teamsnap/apiv3/tree/awe-370-notify-schedule-import, not in master yet.
|
@matthopson Added some tests, validations, and changelog updates. |
CHANGELOG.md
Outdated
There was a problem hiding this comment.
We probably want to bump to 1.8.0 since API change.
Will also want to update in package.json and teamsnap.coffee
|
Just a side-note, it's probably a good idea to include a note + reference to the v3 PR so it's clear it hasn't been merged yet (since the v3 PR needs to be merged before this can be). |
randy-girard
changed the title
randy-girard
force-pushed
the
notify-team-of-events-import
branch
from
82e278b to
b8f5a74
Compare
randy-girard
changed the title
randy-girard
changed the title
|
One more small thing. Would you mind updating https://github.com/teamsnap/teamsnap-javascript-sdk/blob/master/docs/collections/events.md with this? |
|
👍 loop it...
|
randy-girard
force-pushed
the
notify-team-of-events-import
branch
from
a0ebb60 to
6905a05
Compare
Bulk create and notify events
No description provided.