Adds ability to query messages and execute mark as read functionality. #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Need docs and changelog update. |
src/collections/messages.coffee
Outdated
| @loadItems 'message', params, callback | ||
|
|
||
| exports.markMessageAsRead = (id, callback) -> | ||
| params = id: id |
Contributor
There was a problem hiding this comment.
I think it would be nice to be able to use a message object as well as an ID, since that's a convention we've used quite a bit. Thoughts?
Contributor
Author
|
Docs are updated. |
randy-girard
force-pushed
the
message-mark-as-read
branch
from
bd681a7 to
fb8ee40
Compare
Contributor
Author
|
@matthopson Added messageData endpoint too f5e4b0d |
docs/collections/messages.md
Outdated
|
|
||
| ## Methods | ||
|
|
||
| - [loadMessages](#loadMessage) |
randy-girard
force-pushed
the
message-mark-as-read
branch
from
1d51221 to
c25b174
Compare
Contributor
Author
|
@matthopson Updated |
src/collections/messages.coffee
Outdated
| else if @isId params | ||
| params = id: params | ||
| else | ||
| throw new TSArgsError 'teamsnap.markMessageAsRead', 'a message Id or message object must be provided' |
Contributor
There was a problem hiding this comment.
I think it's the capital I that is most bothering me - and maybe wrap in backtics.
See:
Contributor
|
👍 Looks good |
randy-girard
force-pushed
the
message-mark-as-read
branch
from
1051f52 to
946cab1
Compare
Contributor
Author
|
@matthopson This is the PR, when you get a chance to merge it/release :) Thanks! |
Contributor
|
If it's ready you can go ahead and merge. I'll follow up with the npm publish after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.