tweak: Remove PLEASE LET ME OUT from smartfridge#852
tweak: Remove PLEASE LET ME OUT from smartfridge#852ThebeTheSatellite wants to merge 4 commits intoteamstarcup:mainfrom
Conversation
|
I would nevertheless complain to SyndComm that a false alarm message remains unsafe and inappropriate in the workplace environment. SyndComm has a responsibility to not tolerate any misleading programming in our equipment. |
I think I agree; my big problem with the medibot's and smartfridge's lines isn't just that it's weirdly aggro, it's that they're basically pretending to be sapient and trying to trick new players. |
|
I honestly just came up with that on a whim, any suggestions? Or do you reckon I just turn it off as a whole? |
KoboldCatgirl
left a comment
There was a problem hiding this comment.
Looks mostly good! Suggested two minor changes for you to approve, purely for neatness.
I do also have to fuss a little over the neatness of the PR, which is going to feel very annoying but I promise I am not just nitpicking for nitpicking's sake. Our PRs are many people's first introduction to starcup, and they're a big part of our contribution to the broader SS14 community.
Going forward, I'd recommend taking a look at some other PRs for an idea of how they're formatted! That helped me a lot when I was starting out contributing.
Title
In this case, this is a remove: or tweak:, not a fix:. A fix: is about bug fixes and stuff, tweak: is about small minor changes, feat: is for big additions, remove: is for, well, removals, map(Mapname): is for changes to a map, and config:/upstream:/test: are for specialized stuff you likely won't be dealing with anytime soon.
Summary
I would mention that this is a phrase. Like, "SmartFridge will no longer scream 'PLEASE LET ME OUT'" or "Removed 'PLEASE LET ME OUT' from SmartFridge phrases list.
Changelog
So, this one is important. Changelogs actually need to be formatted pretty specifically or they won't work. For some examples from other PRs:
:cl:
- add: Added new doptera sounds from Impstation.
- remove: The ChefVend no longer has five free filled lunchboxes.
- fix: Saltern's Captain and CB Medic no longer have duplicate gear.
- tweak: Handheld radios can now be printed from autolathes!
This allows the Discord bot to convert them into Discord posts with emojis and stuff, as you'll see in our # changelog channel. I will leave it up to you whether this is a Remove or a Tweak.
Co-authored-by: KoboldCatgirl <143960193+KoboldCatgirl@users.noreply.github.com>
Co-authored-by: KoboldCatgirl <143960193+KoboldCatgirl@users.noreply.github.com>
|
thank you for the critiques. I hope that looks better and I'll go through and tweak my other titles and summaries that need it. |
I hate to nag, but the Changelog is still formatted incorrectly! |
my bad is that fixed now? |
no nvm i see the issue will fix on all pr's |
KoboldCatgirl
left a comment
There was a problem hiding this comment.
Looks good! Excited to be free from the silly sapience fakeouts, personally.
Smart fridge no longer randomly says "PLEASE LET ME OUT" and it has been removed from it's phrase pool.
Why / Balance
Tonal change and dialogue designed to confuse new players.
Changelog
🆑