tweak: Increased usability of sustenance vendor

[bruhmogus]

Why / Balance

The sustenance vendor's inventory is pitiful, being empty save for about three items total. You also can't restock it. This fixes that.

Technical details

Added restock just for sustenance vendor, added purchase listing for restock, increased counts of most items in vendor
(all my homies hate git bot)

Media

RUN_THIS.py doesn't do anything useful. It should work!

Changelog
🆑

• add: Added a Sustenance Vendor restock, which can be purchased for 500 spesos by cargo. Starve no more, prisoners!
• tweak: Sustenance Vendors come with more items at roundstart.

[Psymbiote]

Hello! This looks like a good idea to me, I'll ask another team member to give it a review as well. In the meantime, the current title error is fixed by adapting the title so it fits our standard. In this case it would be "tweak: Increased usability of sustenance vendor".

[Psymbiote]

So turns out this was even requested by a team member, I didn't know. I'm not good enough with coding to know what that error is, but if you can fix it, I'll approve it.

[ThebeTheSatellite]

So I had a look myself, the error is related to the NoCargoOrderArbitrage test failing and going further it looks like due to it not being present in cargo_vending.yml there's an issue. Also keep in mind the potential pricing error

I could have searched wrong or found inconclusive stuff but from what I can tell, it's missing from cargo_vending.yml unlike the rest of the restock crates.
Should be fairly easy to fix, add it to the yml, make sure price is a few hundred lower than the prices of items in the vending machine and you should be wicked.

Side note, pretty sure RUN_THIS.py is only supposed to be used once. For actual testing you need to run to runserver.bat then runclient.bat or the .sh ones if you're not on windows.

[bruhmogus]

So turns out this was even requested by a team member, I didn't know. I'm not good enough with coding to know what that error is, but if you can fix it, I'll approve it.

I DIDNT KNOW THAT EITHER

[bruhmogus]

So I had a look myself, the error is related to the NoCargoOrderArbitrage test failing and going further it looks like due to it not being present in cargo_vending.yml there's an issue. Also keep in mind the potential pricing error

I could have searched wrong or found inconclusive stuff but from what I can tell, it's missing from cargo_vending.yml unlike the rest of the restock crates. Should be fairly easy to fix, add it to the yml, make sure price is a few hundred lower than the prices of items in the vending machine and you should be wicked.

Side note, pretty sure RUN_THIS.py is only supposed to be used once. For actual testing you need to run to runserver.bat then runclient.bat or the .sh ones if you're not on windows.

so from the image it looks like it's making sure cargo can't order a restock, bust it open, and sell it for profit? i can further increase the cost of it if thats the issue (aside from the elephant)

[ThebeTheSatellite]

So I had a look myself, the error is related to the NoCargoOrderArbitrage test failing and going further it looks like due to it not being present in cargo_vending.yml there's an issue. Also keep in mind the potential pricing error
I could have searched wrong or found inconclusive stuff but from what I can tell, it's missing from cargo_vending.yml unlike the rest of the restock crates. Should be fairly easy to fix, add it to the yml, make sure price is a few hundred lower than the prices of items in the vending machine and you should be wicked.
Side note, pretty sure RUN_THIS.py is only supposed to be used once. For actual testing you need to run to runserver.bat then runclient.bat or the .sh ones if you're not on windows.

so from the image it looks like it's making sure cargo can't order a restock, bust it open, and sell it for profit? i can further increase the cost of it if thats the issue (aside from the elephant)

that makes sense, honestly I couldn't tell if you were meant to increase or decrease the price from the contents but that makes sense pretty sure. thought it was like an in universe profit from the contents. sounds good.

[bruhmogus]

added a listing to cargo_vending.yml, ready for a rereview so tests can start again

[Psymbiote]

added a listing to cargo_vending.yml, ready for a rereview so tests can start again

I really need to figure out how to make the tests run automatically

[bruhmogus]

five. hundred. reviews.

[bruhmogus]

I HATE ARBITRAGE

[foxcurl]

you can add initialStockQuality: (value) to the VendingMachine component on VendingMachineSustenance to make it less likely to have empty items. the machine inherits a value of 0.33 for this field, meaning 67% of the items choose a value between 0 and the max stock (1 for most). a value of 0.8 might be more fitting, making it so only about 10% of the items are missing on average?

this would be a bit more elegant of an approach than increasing the stocks, i feel, and would let you avoid issues with arbitrage more easily while keeping the restocks useful.

[Psymbiote]

Thank you for your work!