Merged
Conversation
…uncement # Conflicts: # feature/src/main/java/com/terning/feature/dialog/detail/ScrapDialog.kt # feature/src/main/java/com/terning/feature/intern/InternViewModel.kt
4 tasks
boiledeggg
requested changes
Sep 9, 2024
Member
boiledeggg
left a comment
boiledeggg
left a comment
There was a problem hiding this comment.
고생하셨습니다~
스크랩 문제는 서버에서 현재 색상값을 문자열로 받도록 API를 수정했는데 그걸 반영하지 못해 생긴 것 같습니다,,
최대한 빨리 반영하고 PR 올리테니 그거 먼저 머지하고 여기에 반영해서 확인하고 다시 리뷰 요청 부탁드려요!!
Member
|
그리고 메인 검색 화면의 탑바 좌측에 로고는 왜 초록색 박스로 나오는 건가요?? |
Contributor
Author
스크랩 문제 확인했습니다! |
boiledeggg
approved these changes
Sep 9, 2024
leeeyubin
approved these changes
Sep 9, 2024
Comment on lines
+165
to
+168
| internNavGraph( | ||
| paddingValues = paddingValues, | ||
| navHostController = navigator.navController | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
220.mp4
📢 To Reviewers