Merged
Conversation
…-field-view-ui # Conflicts: # core/src/main/java/com/terning/core/designsystem/component/textfield/SearchTextField.kt # core/src/main/java/com/terning/core/designsystem/component/textfield/TerningBasicTextField.kt # feature/src/main/java/com/terning/feature/main/MainNavigator.kt # feature/src/main/java/com/terning/feature/search/SearchRoute.kt
boiledeggg
approved these changes
Jul 11, 2024
Member
boiledeggg
left a comment
boiledeggg
left a comment
There was a problem hiding this comment.
탑바 여백 없어진거 축하~
진짜 속도 엄청 빠르네요,, 너무 고생하셨어요!!
| }) { | ||
| IconButton( | ||
| onClick = { | ||
| onBackButtonClick.invoke() |
Hyobeen-Park
approved these changes
Jul 11, 2024
Member
Hyobeen-Park
left a comment
Hyobeen-Park
left a comment
There was a problem hiding this comment.
탑바 여백 없애기 성공한거 개큰박수 드립니다👏🏻👏🏻
| fun SearchTextField( | ||
| text: String, | ||
| onValueChange: (String) -> Unit, | ||
| text: String = "", |
Member
There was a problem hiding this comment.
요거 String 기본값 추가하신 이유가 궁금해요!!
Contributor
Author
There was a problem hiding this comment.
BasicTextField 기본 속성이라서 삭제하면 에러가 납니당..!
leeeyubin
approved these changes
Jul 11, 2024
Member
leeeyubin
left a comment
leeeyubin
left a comment
There was a problem hiding this comment.
하루에 피알 두 개..!! 수고 넘넘 많았어요~!!
Comment on lines
+17
to
+19
| fun MyPageTopAppBar( | ||
| modifier: Modifier, | ||
| ) { |
Member
There was a problem hiding this comment.
LogoTopAppBar에는 Modifier 기본값을 주고, 여기선 안 준 이유가 있나용,,?
Contributor
Author
There was a problem hiding this comment.
꼼꼼하다,..! MyPage에도 추가하겠습니닷
Comment on lines
+62
to
+63
| colors = TopAppBarDefaults.topAppBarColors(White), | ||
| modifier = Modifier.padding(horizontal = 16.dp) | ||
| windowInsets = WindowInsets(0, 0, 0, 0), |
Comment on lines
+25
to
+27
| Column( | ||
| modifier = Modifier | ||
| .fillMaxSize() |
Member
There was a problem hiding this comment.
위에서 만든 modifier 변수 가져와도 될 것 같아요..!!
Contributor
Author
There was a problem hiding this comment.
이게 사실 효빈님 뷰라서 탑바만 적용한거라 효빈님이 바꿔주신다고합니당ㅎㅎ
Comment on lines
+28
to
+30
|
|
||
| @Serializable | ||
| data object SearchProcess : MainTabRoute No newline at end of file |
Member
There was a problem hiding this comment.
SearchProcess는 바텀바가 없으니까 Route로 해야될 것 같아요!
…to ui/#31-search-text-field-view-ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
31.mp4
📢 To Reviewers