Merged
Conversation
…-field-view-ui # Conflicts: # core/src/main/java/com/terning/core/designsystem/component/textfield/SearchTextField.kt # core/src/main/java/com/terning/core/designsystem/component/textfield/TerningBasicTextField.kt # feature/src/main/java/com/terning/feature/main/MainNavigator.kt # feature/src/main/java/com/terning/feature/search/SearchRoute.kt
leeeyubin
approved these changes
Jul 11, 2024
Comment on lines
+65
to
+69
| ) | ||
| .clickable { | ||
| navController.navigateSearchProcess() | ||
| } | ||
| ) { |
Member
There was a problem hiding this comment.
여기서 noRippleClickable 확장함수 써줘야 리플 효과가 없어질 것 같아요!
Contributor
Author
There was a problem hiding this comment.
진짜 noRipple 테마 너무 편하네용 ㅜ
Comment on lines
+35
to
36
| enabled = enabled, | ||
| readOnly = readOnly, |
Member
There was a problem hiding this comment.
갑자기 궁금해졌는데 readOnly는 어떤 기능을 하는 속성인가요??
Contributor
Author
There was a problem hiding this comment.
저게 텍스트 필드 눌러도 변경할 수 없고 읽을 수만 있도록 하는 속성인데 enabled 속성으로 대체할 수 있어서 지워도 될 것 같습니당!
Hyobeen-Park
approved these changes
Jul 11, 2024
Member
Hyobeen-Park
left a comment
Hyobeen-Park
left a comment
There was a problem hiding this comment.
와 진짜 속도 빠르네요!!! 멋있다.... 키보드 아이콘만 디자인쌤들한테 확인 받으면 될 것 같아요!! 최고최고!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
41.mp4
📢 To Reviewers