[UI/#51] 필터링 재설정 UI 구현 by Hyobeen-Park · Pull Request #76 · teamterning/Terning-Android

Hyobeen-Park · 2024-07-13T21:44:45Z

closed [UI] 홈뷰 / 필터링 재설정 UI 구현 #51

⛳️ Work Description

필터링 UI 구현

📸 Screenshot

Screen_Recording_20240714_064238_Terning-Android.mp4

📢 To Reviewers

모두 모두 진짜 화이팅~~~

…-filter

…-filter # Conflicts: # core/src/main/java/com/terning/core/designsystem/component/topappbar/BackButtonTopAppBar.kt # feature/src/main/java/com/terning/feature/home/home/HomeRoute.kt # feature/src/main/java/com/terning/feature/main/MainScreen.kt

leeeyubin

마지막까지 UI하느라 넘넘 수고많았어용!!!

leeeyubin · 2024-07-15T08:28:43Z

+@Composable
+fun ChangeFilteringRadioGroup(
+    filterType: Int,
+    internFilterData: InternFilterData?,
+    onButtonClick: (Int) -> Unit,
+    modifier: Modifier = Modifier,
+) {


internFilterData가 nullalbe한 이유는 무엇인가용

온보딩에서 필터링을 하지 않고 넘어온 유저들은 필터링 데이터가 없어서 nullable하게 처리했습니다! 필터링 정보가 없는 유저들은 필터링 재설정 화면으로 넘어갔을 때 0번째 버튼이 눌려져 있도록 기본값 설정을 해뒀는데 이 부분은 제가 한번 더 확인해볼게요!!

leeeyubin · 2024-07-15T08:33:09Z

 @Composable
-private fun ShowInternFilter(userNameState: UserNameState) {
-    if (userNameState.internFilter == null) {
+private fun ShowInternFilter(userNameState: UserNameState, navController: NavHostController) {
+    if (userNameState.internFilter?.grade == null) {


NavHostController를 내리지 말구 onChangeFilterClick을 올려서 Route에서 처리하는 건 어떤가요..?

오호!! 한번 고쳐보겠습니다!!

leeeyubin · 2024-07-15T10:19:17Z

+        getRecommendData()
+//        listOf()


주석 이건 안 쓰이는 건가용?

이거 데이터 있을때랑 없을 때를 계속 테스트를 해봐야 해서 이렇게 한건데 지우는거 까먹었네요.. 하핫 머지 하기 전에 지우고 하겠습니다~!!

leeeyubin · 2024-07-15T10:19:39Z


-    val startDestination = SignIn
+    val startDestination = Home


잡기 성공ㅎㅎ

잡았다!! 하핫....

arinming

홈 뷰 하느라 고생 많으셨어요 ㅠ!!!

arinming · 2024-07-15T10:29:57Z

+}
+
+@Composable
+private fun showTitle(


showTitle -> ShowTitle으로 수정해주시면 좋을 것 같습니도~

헉스 수정하겠습니다!

arinming · 2024-07-15T10:30:35Z

+    filterType: Int,
+    internFilterData: InternFilterData?,
+    onButtonClick: (Int) -> Unit,
+    modifier: Modifier = Modifier,


modifier가 쓰이지 않고 있는데, LazyColumn에서 Modifier로 선언하지 않고 modifier 써주시는 건 어떨까요?

오호 좋아요!

arinming · 2024-07-15T10:31:13Z

+    }
+
+    val selectedIndex = remember { mutableIntStateOf(0) }
+    var selectedButton = remember { mutableStateListOf(false, false, false, false) }


var로 선ㄴ언하신 이유가 있나욤?

이게 계속 수정이 되어야 해서 var로 선언했어요!!!

arinming · 2024-07-15T10:33:05Z


        HomeFilteringText(
-            text = grade.toString() + stringResource(id = R.string.home_recommend_filtering_grade),
+            text = grade,


깔끔해졌네요ㅕ~!

arinming · 2024-07-15T10:33:52Z

@@ -112,12 +109,9 @@
    <string name="filtering_button">다음으로</string>

    <!-- changeFilter -->


여기 ChangeFilter로 바꿔주시면 통일감 있을 것 같아요!

네 감사합니다~~!!!

boiledeggg

다들 잘 커멘트 달아줘서 달게 없네요ㅎㅎ 너어어무 고생많으셨습니두~~

…-filter # Conflicts: # feature/src/main/res/values/strings.xml

Hyobeen-Park added 14 commits July 12, 2024 00:54

[FEAT/#51] navigation 설정

293864e

Merge remote-tracking branch 'origin/develop' into ui/#51-home-change…

f694f05

…-filter

[FEAT/#51] 홈 - 필터링 재설정 연결

9d64fcf

Merge remote-tracking branch 'origin/develop' into ui/#51-home-change…

b1e52d4

…-filter

[CHORE/#51] invoke() 삭제

ea2a729

[FEAT/#51] 탑바 적용

603d2eb

Merge remote-tracking branch 'origin/develop' into ui/#51-home-change…

0ec7ef4

…-filter

[FEAT/#51] 탑바 그림자 적용

6e7a7ee

[CHORE/#51] 중복된 string 제거

d09fd0b

[FEAT/#51] 기본 UI 구현

8c8386f

[FEAT/#51] 라디오 버튼 추가

e01f98b

[FEAT/#51] UI 구현

d3e7509

[FEAT/#51] 홈 필터링 데이터 연결

7611e53

Hyobeen-Park added UI 💐 UI 작업 효빈💚 효빈 labels Jul 13, 2024

Hyobeen-Park added this to the 1차 스프린트 UI 작업 milestone Jul 13, 2024

Hyobeen-Park requested review from arinming, boiledeggg and leeeyubin July 13, 2024 21:44

Hyobeen-Park self-assigned this Jul 13, 2024

leeeyubin approved these changes Jul 15, 2024

View reviewed changes

arinming approved these changes Jul 15, 2024

View reviewed changes

boiledeggg approved these changes Jul 15, 2024

View reviewed changes

Hyobeen-Park added 4 commits July 15, 2024 23:47

[CHORE/#51] 함수명 수정

dfd0c0b

[MOD/#51] navController HomeRoute로 이동

76e30b2

[CHORE/#51] 코드 정리

8d02b6b

Merge remote-tracking branch 'origin/develop' into ui/#51-home-change…

0fa6c2f

…-filter # Conflicts: # feature/src/main/res/values/strings.xml

Hyobeen-Park merged commit 5cfdab5 into develop Jul 15, 2024

		@@ -112,12 +109,9 @@
		<string name="filtering_button">다음으로</string>

		<!-- changeFilter -->

Conversation

Hyobeen-Park commented Jul 13, 2024

⛳️ Work Description

📸 Screenshot

📢 To Reviewers

Uh oh!

leeeyubin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arinming left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boiledeggg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants