Add configurable terminal port support and update translations#28
Add configurable terminal port support and update translations#28techartdev merged 6 commits intomainfrom
Conversation
techartdev
commented
Feb 5, 2026
techartdev
commented
- Updated nginx configuration to use a placeholder for terminal port.
- Modified run.sh to read terminal port from options file and start ttyd on the specified port.
- Added terminal port configuration option in English, Bulgarian, German, and Spanish translations.
- Updated nginx configuration to use a placeholder for terminal port. - Modified run.sh to read terminal port from options file and start ttyd on the specified port. - Added terminal port configuration option in English, Bulgarian, German, and Spanish translations.
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable terminal port option to allow users to customize the port used by the ttyd web terminal service, addressing potential port conflicts with other services. The default port remains 7681.
Changes:
- Added
terminal_portconfiguration option with translations in English, Bulgarian, German, and Spanish - Updated nginx configuration template to use a placeholder for the terminal port
- Modified run.sh to read the terminal port from the options file and dynamically configure ttyd
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| openclaw_assistant/translations/en.yaml | Added English translation for terminal_port configuration option |
| openclaw_assistant/translations/es.yaml | Added Spanish translation for terminal_port configuration option |
| openclaw_assistant/translations/de.yaml | Added German translation for terminal_port configuration option |
| openclaw_assistant/translations/bg.yaml | Added Bulgarian translation for terminal_port configuration option |
| openclaw_assistant/nginx.conf.tpl | Replaced hardcoded port 7681 with TERMINAL_PORT placeholder |
| openclaw_assistant/run.sh | Added TERMINAL_PORT variable extraction, debug logging, process cleanup, and Python script integration for dynamic port configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| rm -f "$TTYD_PID_FILE" | ||
| fi | ||
|
|
||
| if [ "$ENABLE_TERMINAL" = "true" ] || [ "$ENABLE_TERMINAL" = "1" ]; then |
There was a problem hiding this comment.
The condition checks for both "true" (string) and "1" (string) values for ENABLE_TERMINAL. However, the jq command on line 23 uses '.enable_terminal // true' which will return a boolean true/false, not the string "1". The check for "1" is unnecessary unless there's a specific use case where the JSON could contain the number 1 instead of a boolean. Consider removing the "|| [ "$ENABLE_TERMINAL" = "1" ]" part for clarity, or add a comment explaining why it's needed.
| if [ "$ENABLE_TERMINAL" = "true" ] || [ "$ENABLE_TERMINAL" = "1" ]; then | |
| if [ "$ENABLE_TERMINAL" = "true" ]; then |
