feat: roadmap path card style changes #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
PR Overview
This PR introduces style updates for the roadmap path card, including new custom icon components and updated UI styling and layout for the study path question cards.
- Added new Check and ERemove icon components.
- Updated styling in the StudyPathQuestionCard component to include dynamic border colors and animations.
- Adjusted the offset calculation in the StudyPathsList for repositioning question cards.
Reviewed Changes
| File | Description |
|---|---|
| src/components/ui/icons/check.tsx | Introduced a new Check component with customizable props. |
| src/components/ui/icons/e-remove.tsx | Introduced a new ERemove component for error state icons. |
| src/components/app/study-paths/study-path-question-card.tsx | Refactored question card layout and replaced lucide-react icons with newly created icon components. |
| src/components/app/study-paths/list.tsx | Updated container styling and modified the offset calculation for positioning cards. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/components/app/study-paths/list.tsx:41
- [nitpick] Verify that the updated offset calculation meets the intended design, as changing the multiplier values significantly increases the offset compared to the previous implementation.
const offsetValue = calculateOffset ? calculateOffset(index) : Math.sin(index * 2.5) * 25;
src/components/ui/icons/check.tsx
Outdated
|
|
||
| function Check(props: iconProps) { | ||
| const fill = props.fill || 'currentColor'; | ||
| const secondaryfill = props.secondaryfill || fill; |
There was a problem hiding this comment.
The variable 'secondaryfill' is defined but not used within the Check component. Consider removing it to simplify the code unless future enhancements require it.
Suggested change
| const secondaryfill = props.secondaryfill || fill; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.