Skip to content

✨ Add a feature showing Streaks#7

Merged
techinpark merged 8 commits intotechinpark:mainfrom
5anniversary:feature/streaks
Feb 25, 2021
Merged

✨ Add a feature showing Streaks#7
techinpark merged 8 commits intotechinpark:mainfrom
5anniversary:feature/streaks

Conversation

@5anniversary
Copy link
Copy Markdown
Contributor

What does this PR do?

1일 1컀밋을 μ‹œμž‘ν•œ μ΄ν›„μ˜ λ‚ μ§œλ₯Ό μ•Œλ €μ£ΌλŠ” κΈ°λŠ₯을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

Why are we doing this?

크둬 μ΅μŠ€ν…μ…˜μ„ 보고

1일 1컀밋이 μ–Όλ§ˆλ‚˜ μ§„ν–‰λ˜μ—ˆλŠ”μ§€ 보게 λœλ‹€λ©΄ μ§€μ†μ μœΌλ‘œ 1일 1컀밋을 μ§„ν–‰ν•˜λŠ” μŠ΅κ΄€μ— 도움이 될 것 κ°™μ•„ μΆ”κ°€ν•΄λ³΄μ•˜μŠ΅λ‹ˆλ‹€.

Screenshots

μŠ€ν¬λ¦°μƒ· 2021-02-25 μ˜€μ „ 12 23 18

@techinpark techinpark self-requested a review February 25, 2021 16:15
Copy link
Copy Markdown
Owner

@techinpark techinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5anniversary 쒋은기λŠ₯ PR μ œμ•ˆ μ£Όμ…”μ„œ κ°μ‚¬ν•©λ‹ˆλ‹€. πŸ‘

μ œμ•ˆμ£Όμ‹  κΈ°λŠ₯이 λ“€μ–΄κ°„λ‹€λ©΄ λ§μ”€ν•΄μ£Όμ‹ λŒ€λ‘œ μŠ΅κ΄€λ§Œλ“€κΈ°μ— 더 도움이 될 것 κ°™μŠ΅λ‹ˆλ‹€.
λ¬Έκ΅¬λŠ” 살짝 λ‹€λ“¬μœΌλ©΄ 쒋을 것 κ°™μ•„μ„œ 의견 λ“œλ €λ΄…λ‹ˆλ‹€.

μ œμ•ˆν•΄μ£Όμ‹  문ꡬ도 μΆ©λΆ„νžˆ μ’‹μ§€λ§Œ, μž”λ””λ₯Ό ν‚€μ›Œκ°„λ‹€λŠ” μ»¨μ…‰μ˜ μ–΄ν”Œλ¦¬μΌ€μ΄μ…˜μ΄κΈ° 떄문에
λŒ€ν™”ν˜•μœΌλ‘œ μ‚¬μš©μžμ—κ²Œ λ‹€κ°€κ°€λŠ” ν˜•νƒœμ˜ 문ꡬ가 μΆ”κ°€λ˜λ©΄ λ”μš±λ” μ’‹μ§€ μ•Šμ„κΉŒ μ‹ΆμŠ΅λ‹ˆλ‹€

- 였늘 처음으둜 μž”λ””λ₯Ό μ‹¬μ—ˆμ–΄μš”
- μž”λ””μ— 싹이 νŠΌμ§€ N일이 λ˜μ—ˆμ–΄μš”  
- μž”λ””κ°€ 무럭무럭 μžλž€μ§€ 10일이 λ˜μ—ˆμ–΄μš” 

μœ„μ™€ 같은 λŠλ‚Œμ΄λ©΄ μ‹€μ œλ‘œ μž”λ””λ₯Ό ν‚€μš΄λ‹€λŠ” λŠλ‚Œμ΄ 듀것 같은데 μ–΄λ–€ μ˜κ²¬μ΄μ‹ μ§€ κΆκΈˆν•©λ‹ˆλ‹€.
μΆ”κ°€λ‘œ 문ꡬ ν•˜λ‹¨μ— .separator() ν•˜λ‚˜ λ„£μ–΄μ£Όμ‹œλ©΄ κ°μ‚¬ν•˜κ² μŠ΅λ‹ˆλ‹€ πŸš€

let dateFormat = DateFormatter()
dateFormat.dateFormat = "yyyy-MM-dd"

guard let timeDateFormat = dateFormat.date(from: self) else {return Date()}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
guard let timeDateFormat = dateFormat.date(from: self) else {return Date()}
guard let timeDateFormat = dateFormat.date(from: self) else { return Date() }

Comment thread Sources/AppDelegate.swift Outdated
var contributeLastDate = count.map(mapFunction)
contributeLastDate.sort{($0.date > $1.date)}
for date in contributeLastDate {
if date.count == 0 {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if date.count == 0 {
if date.count == .zero {

@5anniversary
Copy link
Copy Markdown
Contributor Author

@techinpark

의견 μ£Όμ‹  λ‚΄μš© 반영 ν–ˆμŠ΅λ‹ˆλ‹€.

μ•± 이름이 Jandi라 grassλ‚˜ lawn λ³΄λ‹€λŠ” Jandiκ°€ 더 μ ν•©ν•œ 것 κ°™μ•„, 영문으둜 Jandi둜 선택해 μ˜¬λ €λ‘μ—ˆμŠ΅λ‹ˆλ‹€.

λ˜ν•œ ν˜„μž¬ 컀밋이 λ°˜μ˜λ˜λŠ” λ‚ μ§œμΈ 365일이 생각보닀 적은것 κ°™μ•„ 100λ…„μœΌλ‘œ μ μš©μ„ ν•΄λ†“μ•˜μŠ΅λ‹ˆλ‹€.
싀행을 해도 별닀λ₯Έ λ¬Έμ œκ°€ μ•ˆμƒκΈ°λŠ”κ²ƒ κ°™μ•„ 100λ…„μœΌλ‘œ μ μš©ν•΄ μ˜¬λ¦½λ‹ˆλ‹€!

Comment on lines +22 to +25
"streakFirstStage" = "😒 아직 μž”λ””λ₯Ό 심지 λͺ»ν–ˆμ–΄μš”.";
"streakSecondStage" = "🌱 였늘 처음으둜 μž”λ””λ₯Ό μ‹¬μ—ˆμ–΄μš”.";
"streakThirdStage" = "🌿 μž”λ””μ— 싹이 튼 μ§€ ${day}일이 λ˜μ—ˆμ–΄μš”.";
"streakFourthStage" = "🌳 μž”λ””κ°€ 무럭무럭 μžλž€μ§€ ${day}일이 λ˜μ—ˆμ–΄μš”.";
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ‹€κ΅­μ–΄ ν‚€λŠ”snake_case λ₯Ό μ‚¬μš©ν•˜κ³  μžˆμ–΄ 맞좰 μ£Όμ‹œλ©΄ 쒋을것 κ°™μŠ΅λ‹ˆλ‹€.

Comment on lines +22 to +25
"streakFirstStage" = "😒 I haven't planted Jandi yet.";
"streakSecondStage" = "🌱 I planted my first Jandi today.";
"streakThirdStage" = "🌿 It has been ${day} days since the Jandi sprouts.";
"streakFourthStage" = "🌳 It's been ${day} days since the Jandi has grown well.";
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ‹€κ΅­μ–΄ ν‚€λŠ”snake_case λ₯Ό μ‚¬μš©ν•˜κ³  μžˆμ–΄ 맞좰 μ£Όμ‹œλ©΄ 쒋을것 κ°™μŠ΅λ‹ˆλ‹€.

@5anniversary
Copy link
Copy Markdown
Contributor Author

미처 μ•Œμ§€ λͺ»ν•΄ λ§žμΆ°λ†“μ§€ λͺ»ν–ˆλ„€μš”. λ‹€μ‹œ λ°˜μ˜ν–ˆμŠ΅λ‹ˆλ‹€ 🌱 @techinpark

@techinpark techinpark merged commit 5ad1711 into techinpark:main Feb 25, 2021
@techinpark
Copy link
Copy Markdown
Owner

@5anniversary 쒋은기λŠ₯ κΈ°μ—¬ν•΄μ£Όμ…”μ„œ κ°μ‚¬ν•©λ‹ˆλ‹€ λ‹€μŒ 버전인 v1.6 에 λ°°ν¬λ©λ‹ˆλ‹€ πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants