Skip to content

Improve image sizing for play-lh images #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Improve image sizing for play-lh images #372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/plexus_web/components/core_components.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ defmodule PlexusWeb.CoreComponents do
use Gettext, backend: PlexusWeb.Gettext

alias Phoenix.LiveView.JS
alias Plexus.Schemas.App
alias Plexus.Schemas.Score

@doc """
Expand Down Expand Up @@ -627,6 +628,9 @@ defmodule PlexusWeb.CoreComponents do
"""
end

defp icon_url(%App{icon_url: url = "https://play-lh" <> _}), do: url <> "=w96-h96"
defp icon_url(%App{icon_url: url}), do: url

def card(assigns) do
assigns =
assigns
Expand All @@ -641,7 +645,7 @@ defmodule PlexusWeb.CoreComponents do
<div class="flex">
<div class="aspect-h-1 aspect-w-1 w-24 h-24 bg-white overflow-hidden">
<img
src={@app.icon_url}
src={icon_url(@app)}
alt={@app.name <> " Icon"}
class="h-full w-full object-cover object-center"
/>
Expand Down
Loading