Add unit tests for lookupTranslation and maskChannelStringsWithIdentifiers notification logic#3965
Merged
stephenhand merged 4 commits intoCHI-3736-mask_notificationsfrom Feb 26, 2026
Merged
Conversation
5 tasks
Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add and update unit tests for masking identifiers
Add unit tests for lookupTranslation and maskNotifications
Feb 26, 2026
stephenhand
requested changes
Feb 26, 2026
Collaborator
stephenhand
left a comment
There was a problem hiding this comment.
maskNotifications is now a private function called by maskChannelStringsWithIdentifiers, update the unit tests to test the maskNotifications functionality as part of the maskChannelStringsWithIdentifiers functiob rather than calling it directly
…escribe block Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Contributor
Author
Done in 85f01a7. Removed the standalone |
Copilot
AI
changed the title
Add unit tests for lookupTranslation and maskNotifications
Add unit tests for lookupTranslation and maskChannelStringsWithIdentifiers notification logic
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #3964. Adds missing unit tests for two new methods introduced in that PR.
Description
translations/index.test.ts: AddedlookupTranslationtest suite covering:Manager.strings[code]when key existscodeitself as the Handlebars template when key is absentparametersinto the template@twilio/flex-uiManager.getInstance()and sets upglobal.Handlebarsvia the realhandlebarspackagemaskIdentifiers/index.test.ts: Added coverage for notification masking logic as part ofmaskChannelStringsWithIdentifiers(sincemaskNotificationsis a private function called internally):NewChatMessageoverride handler is registered whenVIEW_IDENTIFIERSis deniednotification.options.browser.titlevialookupTranslation('BrowserNotification-ChatMessage-MaskedTitle')VIEW_IDENTIFIERSis granted../../translationsand@twilio/flex-ui(NotificationIds,Manager,DefaultTaskChannels) to avoidhrmConfigimport chain failures in the test environmentChecklist
Other Related Issues
Original PR: #3964
Verification steps
Run
node_modules/.bin/jest --testPathPattern="(translations|maskIdentifiers)/index"inplugin-hrm-form— all 29 tests should pass.AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.