Fix contactField permission validation to support isOwner condition#1000
Merged
stephenhand merged 2 commits intoCHI-3705-update_field_permissionsfrom Feb 12, 2026
Merged
Conversation
3 tasks
Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update permissions for field modifications based on feedback
Fix contactField permission validation to support isOwner condition
Feb 12, 2026
c41c557
into
CHI-3705-update_field_permissions
29 of 31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
isSupportedContactFieldConditionvalidation function rejectedisOwnerconditions despiteSupportedContactFieldConditiontype includingContactSpecificCondition. This caused contactField permission rules with owner-based logic to fail validation.Changes
isContactSpecificCondition(c)check toisSupportedContactFieldConditionvalidation function inrulesMap.tsThis aligns the runtime validation with the type definition, allowing contactField rules to use the same owner-based permission logic as contact rules.
Checklist
Other Related Issues
Part of stacked PR addressing feedback on #997
Verification steps
Unit tests verify the validation function accepts all types defined in
SupportedContactFieldCondition:cd hrm-domain/hrm-core npx jest unit-tests/permissions/rulesMap.test.tsAFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.