feat: snapshot tests #296
Merged
feat: snapshot tests #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ORDER BY clauses to all critical SQL queries to ensure consistent row ordering * soil_id/db.py: get_hwsd2_profile_data, get_WRB_descriptions queries * soil_id/utils.py: muhorzdataQry, mucompdataQry queries * soil_id/us_soil.py: ESDcompdataQry query - Fix conditional probability sorting with stable tie-breakers in utils.py - Change groupby operations from sort=False to sort=True for deterministic grouping - Add defensive checks in soil_sim.py to handle missing groups gracefully - Fix component naming logic to properly handle duplicate soil names These changes ensure the algorithm produces identical results across multiple runs for the same geographic location, resolving snapshot test failures caused by inconsistent soil component ordering and selection. Fixes non-deterministic issues in: - Global soil identification (Afghanistan, Kenya, Philippines test locations) - US soil identification (Washington, Oregon test locations) - Soil simulation and ranking algorithms Database queries now return rows in predictable order, eliminating race conditions that caused different soil types to be selected between algorithm runs.
garobrik
force-pushed
the
feat/snapshot-tests
branch
from
17e13e3 to
5d0fe1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add snapshot tests, which capture the exact output of the soil ID algorithm at a commit and compare it to new output when the code changes.
Checklist
Related Issues
Fixes #297
Verification steps
Snapshot tests should pass in CI.