fix: update EDIT url #339
Merged
fix: update EDIT url #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesparty
approved these changes
Oct 1, 2025
johannesparty
left a comment
johannesparty
left a comment
There was a problem hiding this comment.
I couldn't review the changes in GitHub.com, but I reviewed using smartgit which is a visual git tool with good diffs. but I could not search for snapshots to make sure old url didn't exist anywhere.
Second, I would be very tempted to create something like edit.torraso.org in cloudflare and have it be a CNAME to edit.sc.egov.usda.gov. I assume the SSL cert would be ok because it uses the one from the CNAME destination, but not 100% sure -- it could be unhappy domain name doesn't match, so we'd want to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the algorithm's return values to use the new ESD URL (details in issue).
Checklist
Related Issues
Fixes, once QA'd, #337
Verification steps
URLs should work now.