Skip to content

Use UTC instead of computer date#13

Merged
bogdanRada merged 1 commit intotechnicalpickles:masterfrom
ericandrewlewis:patch-2
Aug 17, 2017
Merged

Use UTC instead of computer date#13
bogdanRada merged 1 commit intotechnicalpickles:masterfrom
ericandrewlewis:patch-2

Conversation

@ericandrewlewis
Copy link
Copy Markdown

Fixes #12

@bogdanRada
Copy link
Copy Markdown
Collaborator

Hello. Thanks for the pull request and welcome !

I reviewed your pull request and i will merge this monday as i am out of town right now or maybe @technicalpickles will do this maybe earlier. Didn't had time to check this pull request earlier.

This is a really good catch. However i have a bit of a suggestion. According to the Rails team , usually they suggest using Time.zone.now instead of Time.now. i haven't tested it though. I am not sure if that is part of activesupport gem or not. Maybe can You try and see If that works? And submit an update If that is the case. If not i will merge it as it is.

If You have time by monday to check that i will appreciate . But if not i will just merge this commit on monday and will update it If necesarry. Thank You very much for your contribution !

@bogdanRada bogdanRada merged commit b132771 into technicalpickles:master Aug 17, 2017
@bogdanRada
Copy link
Copy Markdown
Collaborator

merged the pull request and released version 1.6.0 on rubygems.org https://rubygems.org/gems/capistrano-gitflow/versions/1.6.0

Thank you very much for your contribution. Have a nice day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants