Skip to content

fix(DateRangeField): Dialog reactivity and stepper offsets #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

fix(DateRangeField): Dialog reactivity and stepper offsets #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67095dc
fix(DateRangeField): Reflect value changes (quick presets, stepper, e…
techniq Oct 23, 2025
14793a0
fix(DateRangeField): Fix stepper offsets
techniq Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bright-sites-wonder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte-ux': patch
---

fix(DateRangeField): Fix stepper offsets
5 changes: 5 additions & 0 deletions .changeset/dry-peas-hear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte-ux': patch
---

fix(DateRangeField): Reflect value changes (quick presets, stepper, etc) in dialog
8 changes: 5 additions & 3 deletions packages/svelte-ux/src/lib/components/DateRangeField.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@

// Field props
export let label: string | null = null;
// export let value = '';
export let error = '';
export let hint = '';
export let disabled = false;
Expand All @@ -75,6 +74,9 @@

let currentValue = value;

// Sync currentValue with value changes (quick preset changes)
$: currentValue = value;

$: restProps = { ...defaults, ...$$restProps };
</script>

Expand Down Expand Up @@ -105,7 +107,7 @@
$localeSettings,
value.periodType
);
const offset = difference(value.from, value.to) - 1;
const offset = -difference(value.from, value.to) - 1;
value = {
from: start(add(value.from, offset)),
to: end(add(value.to, offset)),
Expand Down Expand Up @@ -161,7 +163,7 @@
$localeSettings,
value.periodType
);
const offset = difference(value.to, value.from) + 1;
const offset = difference(value.from, value.to) + 1;
value = {
from: start(add(value.from, offset)),
to: end(add(value.to, offset)),
Expand Down
Loading