Improve display of error messages #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
istathar
added a commit
that referenced
this pull request
Jul 31, 2025
Having gone to the trouble in #57 to present richer error messages, we've needed to go through some refinement to actually emit these appropriate errors in various scenarios. This branch also adds some preliminary efforts to detect malformed or invalid input in such a way that we can guess the user's intent and give a better error as a result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reporting errors, we now report both a succinct error message and a more detailed explanation of what it means and what good input code would look like. To that end, we enrich the details for each of the current failure modes in ParsingError and change TechniqueError to take both.
Update the display of errors to include line and column number, and a pointer to where in the failed line the problem occurred. We also emit the filename, as is conventional in compiler error messsages, which required plumbing the Path through the call stack.
Finally we have updated the check command to have an
--outputoption which takesnativeto dump the AST, otherwise either exiting 1 and reporting the error, or exiting 0 indicating a pass.