Improve detection of problems with signatures #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further improvements to the detection and output of errors.
The "ok" string is now only printed from the technique check command; if running format then it just validates silently before outputting the formatted code.
Filename, line, and columns are now printed consistently in error messages be they concise or full.
A significant improvement is the handling of mistakes made by the user when writing signatures and when those signatures are spread over multiple lines. Both were failing, the first with InvalidProcedure rather than the more specific InvalidSignature you'd expect and the error offset was not pointing to the mistake in the signature.