Colourize examples in error output #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istathar
force-pushed
the
more-colour-errors
branch
from
7097efb to
2a24c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we went to all the trouble of having fancy ANSI colour when formatting code and printing to a terminal (something that Technique v0 did very nicely and we finally caught up with in #61), there's no reason we couldn't use the same styles when rendering help text and examples in compiler error messages.
This ended up extending into a fairly broad refactoring, moving the formatting and display of error messages out of the library crate and into the application layer, renaming a number of (internal) traits and their methods.
Considerable revision of the examples in the errors also accompanied this change.