Remove unnecessary duplicate code formatting implementation #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Turns out this closes #18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons that are not entirely clear, the code to format Technique sources was almost entirely duplicated in the problem module used to embellish code snippets used in examples when printing error messages. Clean up this duplication.
Along the way made some improvements to the way tagging of fragments is done by the formatter code, considerably reducing the amount of allocation being done.
While we have a fairly extensive battery of parsing and formatting tests, the only real way to ensure the overall shape of the output is correct is to have a set of golden tests comparing known-good inputs that must be identical after being formatted. Add a test case which works through any files in examples/golden/ and fail if differences are detected.