Derive PartialEq in enums #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelbuesing
changed the title
marcelbuesing
force-pushed
the
enum-derive-equality
branch
from
37201eb to
91d55f4
Compare
marcelbuesing
changed the title
marcelbuesing
changed the title
marcelbuesing
force-pushed
the
enum-derive-equality
branch
from
91d55f4 to
953c45d
Compare
Member
|
Thanks! I previously didn't add this over concerns of code size bloat but if this becomes an issue we also just put this behind a feature flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make enums compareable. Only derive PartialEq due to possible floats.