Merged
Conversation
Contributor
Author
|
Bug originally reported in issue #31. |
|
I've just been bitten by this, now that Clojure 1.3 has been released. |
Contributor
|
Thanks; sorry for the delay. Will cut a release soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use .getRawRoot against vars, as .getRoot disappeared in Clojure 1.3. References #31.
Should be a safe change: .getRawRoot differs from .getRoot only in that .getRawRoot will not throw if the var has no root. Given that .getRoot is used in clojure-test-mode only against clojure.test/report, and that report is defined as part of the public API of clojure.test, that seems like a reasonable risk to take.