remote/tramp jack-in support, fix a few bugs in jack-in, and improve buffer handling for clojure-test-mode#62
Merged
technomancy merged 10 commits intoclojure-emacs:masterfrom Feb 11, 2012
tavisrudd:master
Merged
remote/tramp jack-in support, fix a few bugs in jack-in, and improve buffer handling for clojure-test-mode#62technomancy merged 10 commits intoclojure-emacs:masterfrom tavisrudd:master
technomancy merged 10 commits intoclojure-emacs:masterfrom
tavisrudd:master
Conversation
This can be used in conjunction with swank.core.server/make-output-redirection and a custom slime-output-target: technomancy/swank-clojure@83546c0 Later, I'll add a clojure-test-mode command to set the output targe location.
This also has slightly nicer window handling, in that it jumps to the slime-repl window and moves to the end of the buffer. NOTE: This depends on matching changes to swank-clojure's 'lein jack-in' command.
Users might have their own variant of this installed. Fortunately, multiple translations don't do any harm.
- this will make it easier to add support for ssh tunnels to remote swank and graceful handling of older versions of swank that don't support 'lein jack-in <port> <hostname>' - also fixes the *slime repl nil* bug, but at the cost of possibly leaving the repl buffer with the wrong default-directory
Contributor
|
Sorry, I let this slip by. Looks good to me. |
technomancy
added a commit
that referenced
this pull request
Feb 11, 2012
remote/tramp jack-in support, fix a few bugs in jack-in, and improve buffer handling for clojure-test-mode
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Phil,
Most of this is that extension to jack-in we talked about. I've refactored it since the first draft to not depend on the extended version of 'lein jack-in' and have added automatic ssh-tunnel support.
There are also two commits here
https://github.com/tavisrudd/clojure-mode/commit/250c1476aa5ba07dfc9122424fe9fdb0b3318124
https://github.com/tavisrudd/clojure-mode/commit/823fb4bf264fbf5721e5d10401eb0ec6afcff7b5
that improve the buffering handling of clojure-test-mode a bit. They add a func for jumping back and forth between tests/impl and auto-jump to the tests if clojure-test-run-tests is called from the impl buffer (in a save-window-excursion block of course).
There's also preliminary support for sending clojure-test-mode ouput to a different buffer, but that needs a bit of a UI before it's ready for use.
Cheers,
Tavis