Skip to content

feat: support rtl (#209) #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2020
Merged

feat: support rtl (#209) #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be7dcd5
feat: support rtl (#209)
technote-space Oct 13, 2020
f6845c9
chore: add sample
technote-space Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion __tests__/functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,10 @@ describe('getCss', () => {
duration: ZERO_SEC,
'padding_bottom': 'a',
cssFilter: css => css,
rtl: true,
});
expect(css).toHaveProperty('background-position');
expect(css['background-position']).toBe('left -100% center');
expect(css['background-position']).toBe('right 0 center');
});

it('should get stripe css', () => {
Expand Down
12 changes: 11 additions & 1 deletion bin/gh-pages/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,17 @@ $(() => {
<p>
Dolly'll never go away again
</p>

<p style="direction: rtl">
<bdo lang="ar" dir="rtl">
<span class="marker-animation" data-ma_rtl="true" data-ma_repeat="true">
هذا اختبار اللغة العربية.
</span>
هل هذه المكتبة تعمل بشكل صحيح؟
<span class="marker-animation" data-ma_rtl="true" data-ma_color="#00ffcc">
إذا كان لديك أي مشاكل ، يرجى الإبلاغ عنها.
</span>
</bdo>
</p>
<p>
<a class="btn btn-light-blue reset-animation">Reset</a>
</p>
Expand Down
1 change: 1 addition & 0 deletions src/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ export const SETTINGS_DEFAULTS = {
cssFilter: function(css) {
return css;
},
rtl: false,
};
24 changes: 21 additions & 3 deletions src/functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,31 @@ export const isStatic = options => options.stripe || (ZERO_SEC === options.delay
*/
export const getCss = options => options.cssFilter(options.stripe ? getStripeCss(options) : getMarkerCss(options));

/**
* @param {object} options options
* @returns {string} direction
*/
const getDirection = options => options.rtl ? 'right' : 'left';

/**
* @param {object} options options
* @returns {string} percentage
*/
const getStartPercentage = options => options.rtl ? '0' : '-100%';

/**
* @param {object} options options
* @returns {string} percentage
*/
const getGoalPercentage = options => options.rtl ? '100%' : '0';

/**
* @param {object} options options
* @returns {object} css
*/
const getCommonCss = options => Object.assign({
'display': 'inline',
'background-position': 'left 0 center',
'background-position': `${getDirection(options)} ${getGoalPercentage(options)} center`,
'padding-bottom': options.padding_bottom,
}, options.font_weight ? {
'font-weight': options.font_weight,
Expand All @@ -82,7 +100,7 @@ const getMarkerCss = options => Object.assign({}, getCommonCss(options), {
'background-repeat': 'repeat-x',
'background-image': `linear-gradient(to right, rgba(255,255,255,0) 50%, ${options.color} 50%)`,
}, isStatic(options) ? {
'background-position': 'left -100% center',
'background-position': `${getDirection(options)} ${getStartPercentage(options)} center`,
} : {});

/**
Expand Down Expand Up @@ -133,7 +151,7 @@ export const stop = target => {
export const onInView = (target, options) => {
target.stop(true, true).css({
transition: `background-position ${options.duration} ${options.function} ${options.delay}`,
'background-position': 'left -100% center',
'background-position': `${getDirection(options)} ${getStartPercentage(options)} center`,
});
if (!options.repeat) {
stop(target);
Expand Down