Add CHD support for SCSI disks and CD-ROMs#17
Merged
Conversation
Wraps libchdman-rs to mount .chd files anywhere a regular disk image is accepted. HD CHDs are writable (in-place for uncompressed, MAME-style .diff.chd sidecar for compressed parents); CD CHDs expose cooked 2048-byte sectors read-only. Vibe coded this PR. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
I just updated the PR to use my crate version, this saves a fair chunk of time as it's using prebuilt binaries for the libchdman-rs library. |
Owner
|
thanks! |
CHD support pulls in libchdman-rs (and a prebuilt native chdman blob), which is unnecessary for users who only use raw disk images. Gate the chd_disk module, DiskBackend::ChdHd/ChdCd variants, and the wd33c93a mount path behind a new `chd` feature, off by default. Mounting a `.chd` path without the feature returns an Unsupported error pointing the user at `--features chd`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
PR has been updated, build with I still think using the prebuilt is much better so that way you don't have to clone the entire mame and build it out, which on Windows is super slow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps libchdman-rs to mount .chd files anywhere a regular disk image is accepted. HD CHDs are writable (in-place for uncompressed, MAME-style .diff.chd sidecar for compressed parents); CD CHDs expose cooked 2048-byte sectors read-only.
Vibe coded this PR.
Tested execution on my Macintosh Pro M4. Figured you might like this