✅ increase test coverage #113

techouse · 2025-10-26T22:06:51Z

This pull request adds new unit tests to improve coverage of error handling and compatibility in the CLI and types modules. The most important changes are grouped below:

CLI error handling tests

Added TestCliErrorPaths class in tests/unit/test_cli_error_paths.py to verify that invalid charset/collation combinations are rejected before transfer starts, and that debug mode properly re-raises KeyboardInterrupt and generic exceptions for easier debugging and development.

Types module compatibility tests

Added a test in tests/unit/test_types_fallback.py to ensure that the types module correctly falls back to using typing_extensions.TypedDict when typing.TypedDict is missing, improving compatibility with older Python versions.

…ation errors

…pedDict is missing

…lization

…d connection error handling

… error handling

coderabbitai · 2025-10-26T22:07:04Z

Warning

Rate limit exceeded

@techouse has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f144a3d and 4958b50.

📒 Files selected for processing (1)

tests/unit/test_transporter.py (6 hunks)

Walkthrough

This pull request introduces comprehensive unit test coverage for the MySQL to SQLite converter, including three new or significantly expanded test modules: CLI error-path validation, transporter edge cases and fallback behaviours, and type system fallback mechanisms. All changes are test-focused with no modifications to production code or public APIs.

Changes

Cohort / File(s)	Change Summary
CLI error-path tests `tests/unit/test_cli_error_paths.py`	Introduces new unit test module covering CLI error scenarios: invalid charset/collation combinations, KeyboardInterrupt propagation in debug mode, and generic exception (RuntimeError) propagation during transfer operations.
Transporter coverage expansion `tests/unit/test_transporter.py`	Extends existing test suite with extensive coverage for constructor validation (UTF-8mb4 collation handling, MySQL connection states), transpilation helpers (_transpile_mysql_expr_to_sqlite, _transpile_mysql_type_to_sqlite, _quote_sqlite_identifier, _translate_default_from_mysql_to_sqlite), data type and collation handling, index generation, CREATE TABLE/VIEW operations, reconnection behaviour, view transfers, and SQLite JSON1 extension state validation.
Type system fallback tests `tests/unit/test_types_fallback.py`	New module verifying fallback behaviour when typing.TypedDict is unavailable; tests module reload under simulated conditions and asserts correct resolution to typing_extensions.TypedDict.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Multiple test files with distinct concerns: CLI error handling, transporter edge cases, and type fallback require separate mental context.
Complex mocking strategies: Tests extensively patch internal helpers and MySQL connection objects; understanding mock behaviour and test intent requires careful attention.
Broad scenario coverage: Constructor validation, transpilation functions, view creation, reconnection paths, and JSON1 checks span diverse code paths; each scenario merits individual review.
Parameterised and fixture-based tests: Verify proper use of public API and correct argument validation.

Possibly related PRs

#111: New transporter and types tests exercise exact helper methods and behaviours (e.g., _transpile_mysql_expr_to_sqlite, _transpile_mysql_type_to_sqlite) that were introduced or modified.
#100: Both PRs touch _translate_default_from_mysql_to_sqlite function and extend tests around default-value translations.
#110: New tests exercise transporter and CLI behaviours (view creation, transfer error/reconnect paths, views_as_views flag) that were added or modified.

Suggested labels

enhancement

Suggested reviewers

zokkis

Poem

🐰 Whiskers twitch with test-ing glee,
Error paths and edge cases free,
Mocks and patches dance with flair,
Coverage blooms beyond compare!
Quality shines from tail to ear,
This test suite's tale is crystal clear! 🧪✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 54.39% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Title Check	❓ Inconclusive	The title ":white_check_mark: increase test coverage" is vague and generic, using non-descriptive language that does not convey meaningful information about the specific changes. While the emoji and phrase are technically related to the changeset (tests are indeed being added), the title fails to highlight what specific areas are being tested, such as CLI error handling or types module compatibility. A teammate scanning the history would not understand the primary focus of these changes from the title alone.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	The pull request description provides clear, well-structured content explaining the changes, including specific class and file names, and describes the motivation for adding these tests (error handling coverage and compatibility with older Python versions). However, it does not follow the required template structure, missing the "Type of change" section with checkboxes, the "How Has This Been Tested?" section, and the "Checklist:" section. Despite these structural gaps, the description successfully communicates the essential information about what was changed and why, which represents the most critical part of a PR description.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-10-26T22:12:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (0ca2dcc) to head (4958b50).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   93.50%   99.11%   +5.61%     
==========================================
  Files           8        8              
  Lines         908      908              
==========================================
+ Hits          849      900      +51     
+ Misses         59        8      -51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

tests/unit/test_cli_error_paths.py (1)

68-96: Consider extracting common kwargs into a fixture.

The large kwargs dictionary is duplicated across both debug tests. Extracting it into a pytest fixture would improve maintainability.

Example:

@pytest.fixture
def debug_cli_kwargs():
    return {
        "sqlite_file": "out.sqlite3",
        "mysql_user": "user",
        "prompt_mysql_password": False,
        "mysql_password": None,
        "mysql_database": "db",
        # ... remaining kwargs
        "debug": True,
    }

Then use it in tests:

def test_debug_reraises_keyboard_interrupt(self, monkeypatch: pytest.MonkeyPatch, debug_cli_kwargs) -> None:
    # ... setup code
    with pytest.raises(KeyboardInterrupt):
        mysql2sqlite.callback(**debug_cli_kwargs)

Also applies to: 112-140

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ca2dcc and f144a3d.

📒 Files selected for processing (3)

tests/unit/test_cli_error_paths.py (1 hunks)
tests/unit/test_transporter.py (6 hunks)
tests/unit/test_types_fallback.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

tests/**

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use pytest; keep tests under tests/ mirroring src/mysql_to_sqlite3/ structure

Files:

tests/unit/test_cli_error_paths.py
tests/unit/test_types_fallback.py
tests/unit/test_transporter.py

tests/unit/test_*.py

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

tests/unit/test_*.py: Add unit tests in tests/unit/ for isolated helpers; create targeted files named test_.py
Add at least one unit test covering new flag behavior/validation
Add unit tests for new type mappings in _translate_type_from_mysql_to_sqlite
Add unit tests for new default expression translations

Files:

tests/unit/test_cli_error_paths.py
tests/unit/test_types_fallback.py
tests/unit/test_transporter.py

{src,tests}/**/*.py

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Adhere to lint suite: Black line length 120 and isort profile=black import ordering for all Python files

Files:

tests/unit/test_cli_error_paths.py
tests/unit/test_types_fallback.py
tests/unit/test_transporter.py

🧠 Learnings (6)

📓 Common learnings

Learnt from: CR
PR: techouse/mysql-to-sqlite3#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-18T21:08:55.973Z
Learning: Applies to src/mysql_to_sqlite3/transporter.py : Extend _translate_type_from_mysql_to_sqlite when adding type mappings and add corresponding tests

Learnt from: CR
PR: techouse/mysql-to-sqlite3#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-18T21:08:55.973Z
Learning: Applies to tests/unit/test_*.py : Add unit tests for new type mappings in _translate_type_from_mysql_to_sqlite